[CLI] Relative paths result in different contracts

[chriseth]

Input:

A.sol:

contract A {}

B.sol:

import "./A.sol";
contract B {}

solc --metadata ./A.sol B.sol results in:

======= ./A.sol:A =======
Metadata: 
{"compiler":{"version":"0.4.25-develop.2018.8.6+commit.7c9bfb62.mod"},"language":"Solidity","output":{"abi":[],"devdoc":{"methods":{}},"userdoc":{"methods":{}}},"settings":{"compilationTarget":{"./A.sol":"A"},"evmVersion":"byzantium","libraries":{},"optimizer":{"enabled":false,"runs":200},"remappings":[]},"sources":{"./A.sol":{"keccak256":"0x883c1af8f1ad6d7cdfb8aaed151eebcdd940c8dae0a659cb38054c7ec32ce890","urls":["bzzr://7ce182fe82cc04e1b5a9c5b29df9dd55ee945ee1879b2768926014ead7f5706c"]}},"version":1}

======= A.sol:A =======
Metadata: 
{"compiler":{"version":"0.4.25-develop.2018.8.6+commit.7c9bfb62.mod"},"language":"Solidity","output":{"abi":[],"devdoc":{"methods":{}},"userdoc":{"methods":{}}},"settings":{"compilationTarget":{"A.sol":"A"},"evmVersion":"byzantium","libraries":{},"optimizer":{"enabled":false,"runs":200},"remappings":[]},"sources":{"A.sol":{"keccak256":"0x883c1af8f1ad6d7cdfb8aaed151eebcdd940c8dae0a659cb38054c7ec32ce890","urls":["bzzr://7ce182fe82cc04e1b5a9c5b29df9dd55ee945ee1879b2768926014ead7f5706c"]}},"version":1}

======= B.sol:B =======
Metadata: 
{"compiler":{"version":"0.4.25-develop.2018.8.6+commit.7c9bfb62.mod"},"language":"Solidity","output":{"abi":[],"devdoc":{"methods":{}},"userdoc":{"methods":{}}},"settings":{"compilationTarget":{"B.sol":"B"},"evmVersion":"byzantium","libraries":{},"optimizer":{"enabled":false,"runs":200},"remappings":[]},"sources":{"A.sol":{"keccak256":"0x883c1af8f1ad6d7cdfb8aaed151eebcdd940c8dae0a659cb38054c7ec32ce890","urls":["bzzr://7ce182fe82cc04e1b5a9c5b29df9dd55ee945ee1879b2768926014ead7f5706c"]},"B.sol":{"keccak256":"0xac4c8a7250ed35c29ffa1b0f2c28e1454084ef3de7fe385a96763ee8faf1125f","urls":["bzzr://2b76fbe8200e4ca3c60410492f1bf1e594adad1bfe0c132063257c0ab06f8c3e"]}},"version":1}

[axic]

@chriseth any proposal to fix this? Should have a well defined path cleaning step?

[chriseth]

Yes, there is a well-defined path cleaning step, as can be seen through import "./A.sol" working properly. We just seem to not apply it from the commandline.

[chriseth]

So to clarify: The issue here is not the import "./A.sol" but instead calling the compiler using solc ./A.sol B.sol instead of solc A.sol B.sol.

[chriseth]

Related: #4623

[chriseth]

We should not just turn the arguments into absolute paths but instead remove the current working directory (or the base path, if given) from the absolute path, if it is a prefix.