Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROJECT] Provide a "src" folder #5429

Closed
ghost opened this issue Nov 14, 2018 · 10 comments
Closed

[PROJECT] Provide a "src" folder #5429

ghost opened this issue Nov 14, 2018 · 10 comments

Comments

@ghost
Copy link

ghost commented Nov 14, 2018

Abstract

Provide a "src" folder, in which all relevant sources are moved in

Motivation

The overall project-structure is currently very clean. An enhancement would be to group the source-code into a "src" folder.

Specification

  • move existent source folders
  • possibly exclude the lll code ("alien" src)
  • optionally, include a README with a subsystems-overview.

Backwards Compatibility

  • Compatible (for solidity project itself)
  • projects which depend/use solidity source directly need to adapt.
@ghost ghost changed the title [PROJECT] Provide a "src" [PROJECT] Provide a "src" folder Nov 14, 2018
@axic
Copy link
Member

axic commented Nov 14, 2018

What is the main benefit of this?

@ghost
Copy link
Author

ghost commented Nov 14, 2018

What is the main benefit of this?

  • The question "where is the relevant source-code" is immediately answered.
  • The root-directory shrinks (and thus it is less overwhelming, especially for newcomers)
  • For some more reasons, this is standard-practice in "java" and "C++" projects (never looked the reasons up, I'm used to have a "src" folder...). I can take a quick look though, if you wish.

@axic
Copy link
Member

axic commented Nov 14, 2018

There is a big disadvantage though: Github will not display any kind of history for moved files (it is a shortcoming in Github, not git - it can be done on the commandline). And since almost every file has to be moved, that is quite bad.

@ghost
Copy link
Author

ghost commented Nov 14, 2018

I see, a known issue, see isaacs/github#900

So, the current workaround would be to use the chrome-extension mentioned in isaacs/github#900, and for sure there are local UI tools which display full history.

@axic
Copy link
Member

axic commented Nov 14, 2018

I know it is a known issue (I follow the thread) and it has received 0 response from Github for 1.5 years, since it is an unofficial repository.

I'm not yet convinced moving stuff before that is more widely available (how many people search for historical commits on the CLI and not on github?) I think it is more of a detriment, than benefit.

@ghost
Copy link
Author

ghost commented Nov 14, 2018

Like many things in project-management, it is a matter of setting priorities.

The issue is: what has priority?

a) A clean (quasi)standard project-structure?
b) "bowing" to (one more) defect of github?

For me it would be quite clear: ignore the github nonsense, and go on - e.g. whilst suggesting to the team an local UI tool (NOT cli), for the case historical code-research is needed).

Despite this, I understand your position.

Can you please clarify if you would be ok with moving code into a src folder, once the history-thing is solved (or at least worked-around) ?

@chriseth
Copy link
Contributor

I'm pretty sure this has a very bad benefit / cost ratio and propose to close this issue.

@ghost
Copy link
Author

ghost commented Nov 15, 2018

I'm pretty sure this has a very bad benefit / cost ratio

... (no comment)

@ghost ghost mentioned this issue Nov 15, 2018
@leonardoalt
Copy link
Member

Can we close this then?

@ghost
Copy link
Author

ghost commented Nov 16, 2018

Can we close this then?

From all issues I've filed here in this project, this one is most possibly the most important one.

But I am now at my limits of "trying to explain the obvious" (thus "no comment").

Please feel free to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants