Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to Ewasm/ewasm #7932

Closed
axic opened this issue Dec 9, 2019 · 6 comments · Fixed by #8055
Closed

Rename to Ewasm/ewasm #7932

axic opened this issue Dec 9, 2019 · 6 comments · Fixed by #8055
Assignees

Comments

@axic
Copy link
Member

axic commented Dec 9, 2019

Yul and the source through contains various spellings of Ewasm. The preferred spelling is "Ewasm" and we should use "ewasm" for CLI options.

One example, the machine flag for Yul uses "eWasm".

@axic axic added the to discuss label Dec 9, 2019
@axic
Copy link
Member Author

axic commented Dec 10, 2019

The only thing needed for 0.6.0 is any public switches in the CLI to use ewasm. Everything else is internal refactoring.

@christianparpart christianparpart self-assigned this Dec 11, 2019
@christianparpart
Copy link
Member

@axic but in JSON it should stay as ewasm I suppose, shouldn't it?

@axic
Copy link
Member Author

axic commented Dec 11, 2019

Oh I've started doing this already, sorry haven't assigned myself.

@christianparpart
Copy link
Member

never mind. looking for something else then (git reset --hard HEAD-ing)

@axic
Copy link
Member Author

axic commented Dec 11, 2019

What I did/plan to do (but not before the 0.6.0 release to avoid conflicts):

  • rename EWasmToText to TextTransform (as it has nothing ewasm specific and it is in line with BinaryTransform)
  • rename EWasmAST to WasmAST (likewise, not ewasm specific)
  • rename eWasm/EWasm to Ewasm in classes/file names
  • ensure all CLI and StandardJSON fields are called ewasm

@axic
Copy link
Member Author

axic commented Dec 11, 2019

There doesn't seem to be any CLI option which uses a non-standard capitalisation of ewasm (it was just a typo in the changelog, fixed by #7954). Standard JSON was always using lowercase.

The renaming is not important for 0.6.0, so moving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants