Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's still early to prepare for the merge #511

Closed
remyroy opened this issue Jun 21, 2022 · 3 comments
Closed

It's still early to prepare for the merge #511

remyroy opened this issue Jun 21, 2022 · 3 comments
Assignees

Comments

@remyroy
Copy link
Contributor

remyroy commented Jun 21, 2022

Some instructions on https://launchpad.ethereum.org/en/merge-readiness might need to wait for an actual TTD value to be published or some clients to update with a baked in TTD value for Mainnet before stakers actually apply them on their machine. Phrasing or notices should be added to account for that.

@hwwhww
Copy link
Contributor

hwwhww commented Jun 21, 2022

Hi @remyroy 👋

I was hesitating about it for this reason as well, but I think we could find a balance between (i) providing the readiness now and (ii) letting stakers understand that we still need the last puzzle to solve it.

@remyroy @wackerow what do you think about we add more warnings around "I am running my own EL/CL client"? For example:

  • add introduction of TTD and make it clear that mainnet TTD is unset
  • invalidate the checkbox for now?

@wackerow
Copy link
Member

wackerow commented Jun 21, 2022

Yeah, I think see your point. @remyroy are you saying that even if users check off all these boxes, they will still have a few things to do before the actual upgrade?

The intent was certainly not to imply that, and I can definitely see how it could add some confusion.

Assuming I understand you correctly, I agree with @hwwhww that we should just make a note of this. Hesitant to remove everything entirely as it's otherwise public info that is out there, just consolidated to help stakers get ready. @hwwhww I kind of like the idea of adding a final checkbox that is disabled, regarding setting the TTD, and we can add a note to make it clear this is not yet available, and to stay tuned.

I am happy to put up a fix for this

@wackerow wackerow self-assigned this Jun 21, 2022
@remyroy
Copy link
Contributor Author

remyroy commented Jun 21, 2022

For instance, some execution client will not open their Engine API endpoint until a TTD is configured (either manually or through their baked in network configuration). There might be a chance to break a validator setup is someone tries to configure everything too early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants