Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: uint should not be used for method signature encoding? #1369

Open
lispc opened this issue Apr 26, 2024 · 1 comment
Open

bug: uint should not be used for method signature encoding? #1369

lispc opened this issue Apr 26, 2024 · 1 comment

Comments

@lispc
Copy link

lispc commented Apr 26, 2024

https://github.com/ethereum/tests/blob/1c23e3c27ac53b794de0844d2d5e19cd2495b9d8/src/GeneralStateTestsFiller/Cancun/stEIP1153-transientStorage/15_tstoreCannotBeDosdFiller.yml#L27C16-L27C44

0x883264e8 is the keccak of doCall(uint). While the solidity spec claimed

uint, int: synonyms for uint256, int256 respectively. 
For computing the function selector, uint256 and int256 have to be used.

So is this correct? Should use doCall(uint256) for signature?

@winsvega
Copy link
Collaborator

winsvega commented May 6, 2024

hm, but it seems to still work when calling solc generated contracts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants