Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BlockchainTests without mining #325

Closed
pirapira opened this issue Sep 18, 2017 · 1 comment
Closed

Introduce BlockchainTests without mining #325

pirapira opened this issue Sep 18, 2017 · 1 comment

Comments

@pirapira
Copy link
Member

#318 (comment)

yes. so lets say if blockchaintest.json has "sealEngine" : "NoProof" then difficulty should not be calculated.
if .json has "sealEngine" : "Ethash" then it works as usual.
if .json has no "sealEngine" field then it should fail as the test is outdated

@winsvega
Copy link
Collaborator

winsvega commented Sep 26, 2017

so @holiman said that having such a blockchain tests will require other clients to disable consensus critical part of the code. and Hive is designed to be a black box tester providing tests as if it was on a real network.
it was agreed to optimize cpp blockchain tests generation instead and keep blockchain tests mining on the lowest allowed difficulty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants