Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'callcreates' field from VM tests #449

Closed
pirapira opened this issue Apr 13, 2018 · 2 comments
Closed

Remove 'callcreates' field from VM tests #449

pirapira opened this issue Apr 13, 2018 · 2 comments
Labels
VMTests

Comments

@pirapira
Copy link
Member

Now that VM tests should not access the world state, the field 'callcreates' should be always empty. So we should remove the field.

Original idea: #444 (comment)
@pirapira pirapira mentioned this issue Apr 13, 2018
Merged
@cdetrio cdetrio mentioned this issue Apr 18, 2018
Closed
@feliam
Copy link
Contributor

feliam commented Oct 11, 2018 •
edited
Loading

Just came here to file the same thing. Remember to remove it also from the docs. (https://github.com/ethereum/tests/blob/develop/docs/test_types/vm_tests.)

@winsvega
Copy link
Collaborator

winsvega commented Apr 7, 2021

VMtests are moved to Legacy
cases migrated to GeneralStateTests

@winsvega winsvega closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
VMTests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pirapira @feliam @winsvega