You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Weeell, I think that's undefined behavior which we should not test. A gazillion things can go wrong all over the place if balances start overflowing, something which cannot ever happen in a live network. It would be a pointless can of worms to start speccing what clients should do in these cases.
In the https://github.com/ethereum/tests/blob/v7.0.0/BlockchainTests/ValidBlocks/VMTests/vmSha3Test/sha3_memSizeNoQuadraticCost31.json test
the initial balance is
tests/BlockchainTests/ValidBlocks/VMTests/vmSha3Test/sha3_memSizeNoQuadraticCost31.json
Line 15 in 5e4539b
and after sending
0x7c
, the final balance istests/BlockchainTests/ValidBlocks/VMTests/vmSha3Test/sha3_memSizeNoQuadraticCost31.json
Line 106 in 5e4539b
Is this the expected way to manage overflows? I think that will have more sense to do saturating overflow or just reject the tx.
(since is filled by geth, cc/@karalabe)
The text was updated successfully, but these errors were encountered: