New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove surf and replace it with reqwest #1446

Closed

KolbyML opened this issue Sep 13, 2024 · 1 comment · Fixed by #1448

Member

KolbyML commented Sep 13, 2024

#1444 Risc-V support is blocked by surf http-rs/surf#352 (comment) surf has been unmaintained for the last 2 years.

It seems like the 2 best options are

hyper
reqwest

Apparently reqwest is built on hyper, with some extra utils which is nice

KolbyML changed the title ~~Remove surf with reqwest~~ Remove surf and replace it with reqwest

This was referenced Sep 13, 2024

refactor: remove unmaintained surf for reqwest #1448

Merged

Support risc-v #1444

Open

Collaborator

morph-dev commented Sep 13, 2024

I just want to highlight that we already depend on both hyper (in rpc and ethportal-peertest ) and reqwest (in light-client) in our repo.

I think #1448 (replace surf with request) can go as is, but I think we should create separate PR to migrate hyper to reqwest as well.

KolbyML closed this as completed in #1448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment