fix issue #1423 #1735
fix issue #1423 #1735
Conversation
| @@ -253,16 +253,10 @@ Method.prototype._confirmTransaction = function (defer, result, payload) { | |||
| } | |||
There was a problem hiding this comment.
Can you please do this changes in a new branch an submit this PR against 1.0? Because it has nothing to do with the new ABI lib. Thanks :)
|
Sure! my bad. Should I just merge this commit into 1.0 branch or create a new branch against 1.0 and cherry pick this commit onto it? I am a newbie on github, please help me, thanks :-) |
|
@leon740727 i would create a new branch with 1.0 as base and cherry pick the commits :) |
|
@nivida thanks! :) |
|
Can you add tests, i dont see how your fix is related to timeout blocks? |
|
sorry, I am very busy recently :-( |
fix issue #1423
I am using web3.eth.sendSignedTransactio on websocket provider, and it won't get receipt in first time, but if wait some seconds, it will get the receipt.
In the program, it will unsubscribe the newBlockHeaders listener immediately when failed to get receipt, that is why I got error, we should let it try until TIMEOUTBLOCK exceed.