Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types of the management modules improved #2720

Merged
merged 31 commits into from
Apr 27, 2019
Merged

Types of the management modules improved #2720

merged 31 commits into from
Apr 27, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Apr 23, 2019

Description

@princesinha19 created a lot of modules which will provide the missing methods from the management JSON-RPC API. For not annoy him too much did I decide to go through the types and documentation later when all the modules are merged.

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Apr 23, 2019
@coveralls
Copy link

coveralls commented Apr 23, 2019

Coverage Status

Coverage increased (+0.02%) to 95.941% when pulling 0470903 on types/new-modules into fa6b570 on 1.0.

@nivida nivida removed the In Progress Currently being worked on label Apr 27, 2019
@nivida nivida merged commit 54325df into 1.0 Apr 27, 2019
@nivida nivida deleted the types/new-modules branch April 30, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants