eth.accounts.signTransaction method fixed #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…saction method updated
nivida
added
Bug
cgewecke
reviewed
Oct 18, 2019
cgewecke
reviewed
Oct 18, 2019
There was a problem hiding this comment.
This LGTM although it seems like it would break current expectations for Ropsten etc - e.g. that accounts.signTransaction can be used with a non-mainnet chain without any special configuration.
@nivida Per your idea in chat have added some logic to automatically generate an ethereumjs-common options object when no hardfork, chain or common is specified.
That's in PR targeting this PR at #3143. If you have a chance could you check that out and advise?
* Auto fetch tx signing option values when not set by user * public api simplified if someone wants to pass custom chain configuration (ethereumjs-common) * default properties added (chain, hardfork, and common) and related types updated
…b3.js into issue/new-signing-parameters
…ted in the Method class of the web3-core-method module
…b3-eth-contract module
This was referenced Mar 31, 2020
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* signTransaction updated, getId method in net module, and e2e signTransaction method updated * types and documentation for accounts.signTransaction updated * example for custom common added * CHANGELOG.md updated and url added to accounts.signTransaction documentation * error msg improved * web3-eth sendTransaction documentation updated * parameter validation updated for accounts.signTransaction method * Auto fetch tx signing option values when not set by user (web3#3143) * public api simplified if someone wants to pass custom chain configuration (ethereumjs-common) * default properties added (chain, hardfork, and common) and related types updated * documentation updated for new default properties * typo fixed in docs and conditions for the new default properties updated in the Method class of the web3-core-method module * funcDocs fixed in utils and missing option properties added in the web3-eth-contract module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ethereumjs-tx package requires additional parameters.