[ethpm] Support ENS in Registry URIs #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
changed the title
njgheorghita
force-pushed
the
ethpm-support-ens-in-registry-uri
branch
3 times, most recently
from
fc89b2a to
3c99fcb
Compare
|
ping @pipermerriam for 👀 |
pipermerriam
approved these changes
Nov 7, 2019
ethpm/backends/registry.py
Outdated
| if ns.address(address_or_ens): | ||
| address = ns.address(address_or_ens) | ||
| ens = address_or_ens | ||
| elif is_address(address_or_ens): |
There was a problem hiding this comment.
Seems like you might want this one to come first in the if/elif ordering since it's a simpler check and might be the more common case.
| @@ -78,11 +82,23 @@ def parse_registry_uri(uri: str) -> RegistryURI: | |||
| """ | |||
| Validate and return (authority, pkg name, version) from a valid registry URI | |||
| """ | |||
| from web3.auto.infura import w3 | |||
There was a problem hiding this comment.
It would be ideal if we could setup a test chain and install the ENS infrastructure on it easily so that we could test this stuff locally without hitting infura. Maybe that's a project for the Web3.py codebase to support under something like web3.tools for doing one-step setup of all of the ENS contracts on a development chain.
njgheorghita
force-pushed
the
ethpm-support-ens-in-registry-uri
branch
from
3c99fcb to
f263445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
ENS support was needed in ERC1319 URIs.
Todo:
Cute Animal Picture