Fix SyntaxWarning #1498
Merged
Fix SyntaxWarning #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`is` and `is not` are identity operators, that check if they are the same objects, which is not what we want when comparing on these cases. Change to use the equality operators `==` and `!=`
|
The CI is failing with this change, which probably mean that it have uncovered a test that was passing before when it should be failing. |
|
Thanks @Fedalto. It looks like a bug to me too. I'll take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Python is complaining with a SyntaxWarning when comparing with literals using
is/is notisandis notare identity operators, that check if they are thesame objects, which is not what we want when comparing on these cases.
How was it fixed?
Change to use
==and!=where appropriateTodo:
Cute Animal Picture