-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade websockets to 10.1 ? #2272
Comments
Yes please upgrade the requirement for Thank you. |
+1 for this. Python 3.10 needs v10 |
+1 Also in dependency hell due to this one. If it's not easy to upgrade, is it possible to make in an optional dependency, e.g. web3[websockets] or web3[all] includes this dependency but otherwise excluded? |
👀 Thanks for chiming in, everyone. It's on our list but it will be a little bit until we can get to it. If anyone has bandwidth to raise a PR in the meantime, we'd be happy to review. That's likely the fastest course of action. It looks like bumping to v10 results in a bunch of deprecation warnings around the |
No bandwidth right now unfortunately, but we can push back our web3 integration to give you more time; may be more urgent for others. For reference: the relevant conflicts for us are the latest |
@kclowes just out of curiosity is the plan to go ahead and remove the ability to pass in the event loop to the websocket provider or deprecate it for now. Here is the associated documentation about the ability to pass in an event loop being deprecated in websockets docs,. The websockets docs say to look at the python 3.10 release notes python release notes, at the bottom it talks about changes to |
I don't know yet. I think we'll probably deprecate in v5 and remove in v6, but I haven't really looked at it too hard. |
For anyone following along, I ended up taking out the loop parameter. I still need to deprecate in v5, which is tracked in #2344. Websockets v10 is a breaking change, so will only be available in v6. I'll plan to put out the first v6 beta release sometime next week with minimal breaking changes so that you can pin to that version if you need websockets v10. |
Hey guys, this still seems to be an issue. Can't use solana with web3. @kclowes What should we do here? |
@dino-rodriguez Try web3 v6.0.0-beta.1. |
pip freeze
outputWhat was wrong?
Currently in dependency hell trying to use solana-py and web3 in same service. solana-py requires websockets 10.1, web3 seems to not support that. Below is the changelog for 10.1 release of websockets, there are no incompatible changes. Any chance I could bother the team to consider upgrading support to 10.1?
Also, from my logs it seems web3 needs "websockets<10" but i think changes were made to support 10.0 (#2175) . May need to update requirements:
remote: The conflict is caused by:
remote: solana 0.19.0 depends on websockets<11.0 and >=10.1
remote: web3 5.25.0 depends on websockets<10 and >=9.1
https://websockets.readthedocs.io/en/latest/project/changelog.html#id3
Thanks!
How can it be fixed?
Upgrade websockets support to 10.1
Note: We prefer to use issues to track our work. If you think you've encountered a bug in web3py or
have a feature request, you're in the right place. If you have implementation or usage questions,
please refer to our documentation and/or join the conversation
on discord.
The text was updated successfully, but these errors were encountered: