Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snake case remaining main API methods and properties #2598

Closed
10 tasks done
wolovim opened this issue Aug 8, 2022 · 7 comments
Closed
10 tasks done

Snake case remaining main API methods and properties #2598

wolovim opened this issue Aug 8, 2022 · 7 comments
Labels
v6 Breaking changes that were considered for v6 (old)

Comments

@wolovim
Copy link
Member

wolovim commented Aug 8, 2022 •
edited by kclowes
Loading

What was wrong?

In web3/main.py there are a few properties and methods that have managed to avoid snake casing so far.

How can it be fixed?

  • encoding/decoding: toBytes, etc.
  • currency utilities: toWei, fromWei
  • address utilities: isAddress, etc.
  • clientVersion
  • solidityKeccak
  • isConnected
  • ENS fromWeb3
  • contract.py:
    • BaseContractEvent: processReceipt, processLog, createFilter + kwargs in createFilter
    • ContractEvent + AsyncContractEvent: getLogs
@wolovim wolovim added the v6 Breaking changes that were considered for v6 (old) label Aug 8, 2022
This was referenced Sep 12, 2022
Merged
Merged
@linda-le1
Copy link
Contributor

I can get going on snake casing clientVersion.

@linda-le1 linda-le1 mentioned this issue Oct 20, 2022
Merged
1 task
@kclowes kclowes mentioned this issue Oct 26, 2022
Closed
22 tasks
@linda-le1
Copy link
Contributor

Will get going on solidityKeccak next.

@linda-le1 linda-le1 mentioned this issue Nov 1, 2022
Merged
1 task
@linda-le1
Copy link
Contributor

Working on fromWeb3 next

@linda-le1 linda-le1 mentioned this issue Nov 1, 2022
Merged
1 task
@linda-le1
Copy link
Contributor

linda-le1 commented Nov 3, 2022 •
edited
Loading

Working on snakecasing the encoding/decoding helpers (toBytes, toHex, toInt, toJSON, and toText)

@linda-le1 linda-le1 mentioned this issue Nov 3, 2022
Merged
1 task
@linda-le1
Copy link
Contributor

Working on snakecasing address helpers (isAddress, isChecksumAddress, andtoChecksumAddress) next

@linda-le1 linda-le1 mentioned this issue Nov 3, 2022
Merged
1 task
@linda-le1
Copy link
Contributor

Working on snakecasing the contract.py methods listed

@linda-le1 linda-le1 mentioned this issue Nov 3, 2022
Merged
1 task
@kclowes
Copy link
Collaborator

kclowes commented Jan 11, 2023

I believe this has been completed! 🎉 Thanks @linda-le1!

@kclowes kclowes closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v6 Breaking changes that were considered for v6 (old)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wolovim @kclowes @linda-le1