Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up StateManager.touched #267

Closed
axic opened this issue Feb 3, 2018 · 0 comments · Fixed by #287
Closed

Clean up StateManager.touched #267

axic opened this issue Feb 3, 2018 · 0 comments · Fixed by #287
Labels
help wanted package: vm

Comments

@axic
Copy link
Member

axic commented Feb 3, 2018

It is an array of addresses which are touched during a tx:

  • appended to in StateManager.putAccount
  • appended to in StateManager.putContractAccount
  • runCall.addTxValue
  • runCode clears it
  • runTx appends to it in two places
  • runTx iterates it and deletes touched, but empty accounts

This should be done in a much cleaner manner, perhaps with an event emitted from StateManager for touching an account and subscribing to that event in runTx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean-up state-manager.touched mattdean-digicatapult/ethereumjs-vm
4 participants
@axic @evertonfraga @wanderer @jwasinger