Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Travis tests in favor of Circle CI #313

Closed
holgerd77 opened this issue Jul 20, 2018 · 4 comments
Closed

Drop Travis tests in favor of Circle CI #313

holgerd77 opened this issue Jul 20, 2018 · 4 comments

Comments

@holgerd77
Copy link
Member

holgerd77 commented Jul 20, 2018

Roundtrip times for running tests on Travis are really annoying - here is a random PR #311 as an example - with Travis tests taking around one hour, while Circle settling down in under 10 minutes.

This significantly lowers productivity by sometimes just waiting and a substantial organizational extra effort if one just wants to review and or rebase 3-4 PRs on a same day.

Furthermore it also significantly discourages going on on more roundtrips to make improvements on current work, which at the end contributes to lower overall code quality.

Should we consider dropping Travis tests and just rely on Circle or does this bring significant extra benefits I am maybe not seeing here?

@axic
Copy link
Member

axic commented Jul 20, 2018

There is no reason for travis if all the same cases are covered by circleci. The only benefit could be keep it disabled so it can be enabled in case of a circleci outage, however that would mean the configuration must be kept up to date and for that exceptional case I do not think it is worth the effort.

@holgerd77
Copy link
Member Author

Ok, I've the set the mandatory tests to pass for master branch merges from Travis to Circle and deactivated the Travis builds directly on the Travis settings page (so not touching the integration on GitHub).

Will test this now by rebasing a random PR.

@holgerd77
Copy link
Member Author

Test this with different PRs, this is working for both failing and succeeding PRs. I think we can go with this from now on.

Will leave this open a bit longer for notice.

@holgerd77
Copy link
Member Author

Move to CircleCI is complete with now also Coveralls runs being switched (#317), will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants