Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLS: use noble-curves MSM #3626

Open
paulmillr opened this issue Sep 2, 2024 · 4 comments
Open

BLS: use noble-curves MSM #3626

paulmillr opened this issue Sep 2, 2024 · 4 comments

Comments

@paulmillr
Copy link
Member

It has been implemented here https://github.com/paulmillr/noble-curves?tab=readme-ov-file#multi-scalar-multiplication

It would appear in v1.6.0 which is yet to be released, but could be tested right away.

@jochem-brouwer
Copy link
Member

Just to check, we would use this method for msmG1 and msmG2 (with their respective methods) in evm/src/precompiles/bls12_381/noble.ts right? Since it currently does "just multiply" the array, and not this multi-multiplication.

@paulmillr
Copy link
Member Author

Yes

@holgerd77
Copy link
Member

Just to note: v1.6 has now been released, so this issue can be tackled. Also to note, that this has not necessarily to be done by the team members involved with the BLS code, since this is a very local change.

In fact it might be a nice occasion to first-round engage with the BLS precompile code in a small way!

@holgerd77
Copy link
Member

Test runs for this can be taken from #3471
(ethereum-tests test runs a lot more relevant then our own tests, these are basically doing nothing except stating that the precompile is there at all 😂 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants