Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockchain: Add debug Logger #3671

Closed
holgerd77 opened this issue Sep 16, 2024 · 1 comment
Closed

Blockchain: Add debug Logger #3671

holgerd77 opened this issue Sep 16, 2024 · 1 comment

Comments

@holgerd77
Copy link
Member

When working on the debug logger docs here #3663 we (re-)discovered that the blockchain package has not even a basic debug logger for the core functionality.

Since blockchain is also a very procedural library it makes a lot of sense to add at least some basic debug logging to at least the core steps of the longer methods like (that's totally in the center) the putBlocks flow and maybe the validation methods. For the others (methods) I would suggest a bit spare and not overdo, maybe one for delBlock() or so, surely not for things like getIteratorHead() (at least I would think so?).

I think if we have these basic logging functionality in some few additional logging lines not added in this first round will then also add naturally if someone looks into something and then misses some output.

@scorbajio
Copy link
Contributor

Closed by #3676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants