-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and improve coverage #449
Comments
|
Eventually for 2. some of the structure of the old |
Closed
Will close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Will go a bit through the current
master
coverage build to roughly identify uncovered code parts to get a bit more of the total picture.Goals are a bit in both directions:
Some first things:
Byzantium
leaving the new opcodes oncovered (or reported to be covered at least), this PR is addressing this: Complete switch to Petersburg on tests | Fix coverage #448Constantinople
(the old one) fork rules for coverage the whole newSSTORE
test is now left completely untested, we actually do might want to reintegrate some of just removedconstantinopleSstoreTest
test cases (see Test cleanup #437) to get some basic coverage, but maybe just as some single test cases in the new runCode API tests in some adopted format. Eventually these tests need also some modified setup to be a bit more flexible on adding new test cases, nevertheless a superb start that we have that at allEXP
opcode and get rid of the file. I did a short test because I thought if there might be some performance reason for the code, but even running thisfor (let i=0; i<1000000; i++) { pow32 = new BN('010000000000000000000000000000000000000000000000000000000000000000', 16) }
doesn't take a significant amount of time, addressed in Replaced static vm logTable with dynamic inline version in EXP opcode #450List is likely not complete, if you have additions feel free to directly edit the post, eventually with closing with your GitHub name on the list item.
The text was updated successfully, but these errors were encountered: