Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishing up for beta and final v4 Releases #544

Closed
5 of 7 tasks
holgerd77 opened this issue Jun 13, 2019 · 8 comments
Closed
5 of 7 tasks

Finishing up for beta and final v4 Releases #544

holgerd77 opened this issue Jun 13, 2019 · 8 comments

Comments

@holgerd77
Copy link
Member

holgerd77 commented Jun 13, 2019

Finalization issue for the work done towards the v4 release (see list of merged PRs), some discussion on this also happening here #455.

@s1na @alcuadrado Seems we are loosing a bit oversight 😄, can you add all things which still needs to be finished here (directly in this first comment by editing) so that we can finish up on the v4 release?

Finalize before beta release

  • @s1na: Promisify runBlockchain, runBlock,... APIs [REFERENCE MISSING]

Finalize before final release

@holgerd77 holgerd77 changed the title Finishing up for beta v4 Release Finishing up for beta and final v4 Releases Jun 13, 2019
@holgerd77
Copy link
Member Author

Update: have extended this a bit to also include finalization todos for the final release. If the list above gets to extensive we can also very well go through 2-3 beta releases if we find appropriate and/or better fitting.

@holgerd77
Copy link
Member Author

@s1na @alcuadrado After having compiled down the release notes #547 I think we can very well do the beta release on Wednesday and leave the other points from above for either a subsequent beta release or the final release. Nothing seems so substantial to me to really need a further delay and I think its also good to get something out to reduce the psychological burden of further collecting stuff and make things bigger and bigger. 😛

What do you guys think? If you've got some last minute work on Monday or so (Tuesday maybe not) feel free to do.

Cheers
Holger

@s1na
Copy link
Contributor

s1na commented Jun 17, 2019

@holgerd77 Thanks for compiling the comprehensive release notes! I think that makes sense. I would still like to add some documentation (specially to the re-structured code), and my personal preference would have been to improve the naming (of Loop and Interpreter which I've grown to hate 😄) before the release. I would appreciate some brainstorming on this as I'm not the best at naming stuff. But I guess these could also be done in subsequent beta or the final release as well.

@holgerd77
Copy link
Member Author

Gna, no hurry, then let's do the first beta earliest mid next week, more important that everyone feels comfortable with the changes (especially you who has done most of the work). 😄

@s1na
Copy link
Contributor

s1na commented Jun 17, 2019

Ah no I didn't mean to stall the release. What I meant was, let's keep Wednesday as the target, and I will try to add some docs before that (hopefully) and if I couldn't make it, well, it will go to subsequent releases :)

@holgerd77
Copy link
Member Author

Really not sure on this myself. The docs should be relatively consistent also for the beta release, and we should also have this renaming done, otherwise it get's confusing if we switch in-between for such central components, otherwise it also get's confusing to have these old names around in the release notes since most people will refer to these initial release notes as primary what's-changed notes.

Let's see if we get some progress on these two things during next 24-36 hours, otherwise we might want to do rather next week.

@alcuadrado
Copy link
Member

alcuadrado commented Jun 28, 2019

This is about simplifying ExecResult, which was discussed in this PR: #529

I'll give it a try. Will probably get back with lots of questions :)

@holgerd77
Copy link
Member Author

Closed by #571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants