Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ethereumjs-util to v6.2.0 and fix test failures #619

Closed
s1na opened this issue Nov 20, 2019 · 0 comments
Closed

Update ethereumjs-util to v6.2.0 and fix test failures #619

s1na opened this issue Nov 20, 2019 · 0 comments
Labels
effort: E1 hours good first issue package: vm prio: P3 important type: tests

Comments

@s1na
Copy link
Contributor

s1na commented Nov 20, 2019

ethereumjs-util v6.2.0 comes with stricter input validation in toBuffer (see ethereumjs/ethereumjs-util#197), and doesn't accept strings that are not prefixed with 0x. I modified the util semver to ~v6.1.0 in #607 for now. We should update util to the newest version and fix the test failures. I don't think we use toBuffer with strings in the main codebase, as such the test failures are mostly in the test cases I guess.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: E1 hours good first issue package: vm prio: P3 important type: tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evertonfraga @s1na