Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing nightly build #928

Closed
evertonfraga opened this issue Oct 28, 2020 · 3 comments · Fixed by #931
Closed

Failing nightly build #928

evertonfraga opened this issue Oct 28, 2020 · 3 comments · Fixed by #931
Assignees

Comments

@evertonfraga
Copy link
Contributor

The nightly build failures are due to massive Constantinople test failures for both State and Blockchain.

The current CI structure does not make easy to inspect specific errors, as they are under a single command (npm run test:state:allForks), so I had to run each test suite to investigate it:

image

@jochem-brouwer
Copy link
Member

This is very suspicious, especially because it is one HF! Why does Constantinople throw?

@evertonfraga
Copy link
Contributor Author

evertonfraga commented Oct 28, 2020

I'll dive into root causes after running the blockchain tests, which can't be run in parallel, because of db resource allocation (the path is fixed).

For blockchain tests, a bunch of:

Error: invalid receiptTrie

For state tests:

Error: the state roots should match

@evertonfraga
Copy link
Contributor Author

After a git bisect session, I found the offending PR: #889, which has some Constantinople-specific code changes.

@cgewecke can you quickly spot the error here? Otherwise I can debug with more depth. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants