Fixes randomStatetest643 exception #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. Pls change this line (https://github.com/ethereumjs/ethereumjs-vm/blob/master/tests/tester.js#L16) as well so that the test is run. then rebase against master, and I will approve. |
…, this avoids BN assertion failure when returnFee is bigger than 0x4000000
hugo-dc
force-pushed
the
fix-huge-return-fee
branch
from
73b156d to
919b5d0
Compare
|
@jwasinger , removed test from skipped tests and rebased against master. |
jwasinger
approved these changes
Nov 25, 2017
|
Thanks |
axic
reviewed
Nov 29, 2017
|
|
||
| // avoid BN assertion failure when returnFee is greater than 0x4000000 | ||
| if (returnFee > gasLimit.toNumber()) { | ||
| returnFee = gasLimit.toNumber() + 1 |
There was a problem hiding this comment.
Should this instead emit an "internal error" here? It would be more straightfoward as this one is causing an OOG below, but it is not clear without reading the next if.
holgerd77
added a commit
that referenced
this pull request
Mar 11, 2021
Add basic API tests for re-exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current exception in randomStatetest is because an assertion in the bn.js module, it checks that the number to be added is less than 0x4000000
https://github.com/indutny/bn.js/blob/master/lib/bn.js#L2129
These changes checks returnFee, if its greater than gasLimit set it as gasLimit + 1, this avoids BN assertion failure when returnFee is bigger than 0x4000000 and ending as an OOG exception as expected.
Closes #195