Restrict direct stack usage in opfns #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Dec 15, 2017
| @@ -470,6 +470,8 @@ module.exports = { | |||
| return loaded | |||
| }, | |||
| DUP: function (runState) { | |||
There was a problem hiding this comment.
Actually for DUP we could change the opcodes table to say takes 1 off and pushes 2 new items, but that makes it just more complex here.
|
@hugo-dc I cannot yet request a review until you join the org, but please ave a look |
axic
commented
Dec 15, 2017
| @@ -1023,8 +1028,7 @@ function makeCall (runState, callOptions, localOpts, cb) { | |||
| // check if account has enough ether | |||
| // Note: in the case of delegatecall, the value is persisted and doesn't need to be deducted again | |||
| if (runState.depth >= fees.stackLimit.v || (callOptions.delegatecall !== true && new BN(runState.contract.balance).lt(callOptions.value))) { | |||
| runState.stack.push(Buffer.from([0])) | |||
| cb(null) | |||
| cb(null, Buffer.from([0])) | |||
There was a problem hiding this comment.
I think this is the reason which makes #222 fail on calls.
|
Changes looks good, I added the changes to my local copy and now all tests are passing. 👍 |
jwasinger
approved these changes
Dec 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue found in #222.