Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external statemanager in VM constructor #264

Merged
merged 2 commits into from
Feb 3, 2018
Merged

Conversation

axic
Copy link
Member

@axic axic commented Feb 2, 2018

Fixes #33.

@axic axic requested a review from holgerd77 February 2, 2018 00:00
@axic
Copy link
Member Author

axic commented Feb 2, 2018

@kumavis do you think this is enough to solve #33?

@yann300 this should also simplify Remix's code.

@holgerd77
Copy link
Member

Probably will already ease things. I have a bit the fear, that the API remains too implicit, if StateManager is still coupled with the VM and not documented explicitly. Would it still be worth the work/pursue the idea to publish this as a separate module like proposed by @wanderer in the issue #33 description?

Just started to wrap my head around this though, so have not formed an opinion myself on this.

@axic
Copy link
Member Author

axic commented Feb 2, 2018

The goal of this is to make it less error prone for those who already modify it to do so. State manager should be cleaned up and/or redesigned but that may take a while (forever?). Probably a good middle ground is having this patch, but marking opts.stateManager as EXPERIMENTAL so that we can make breaking changes to the statemanager API as we do not commit to the current one.

jwasinger
jwasinger previously approved these changes Feb 3, 2018
Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeps backwards compatibility while offering additional flexibility to ethereumjs-vm users. I approve!

@axic
Copy link
Member Author

axic commented Feb 3, 2018

@holgerd77 added a bold EXPERIMENTAL warning to it.

@jwasinger please reapprove if still happy

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this EXPERIMENTAL placing in the API docs, will approve.

@axic axic merged commit f0abd93 into master Feb 3, 2018
@axic axic deleted the statemanager branch February 3, 2018 18:49
@axic axic removed the in progress label Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StateManager Should be public
4 participants