Run blockchain tests as default on CI #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d blockchain test runs
|
No production code touched, tests are still passing, will merge. |
This was referenced Oct 30, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest test-related PR merge now using the
sealEnginefield from the tests - see #373 - blockchain tests are now fast enough to be run as default on every PR.This PR:
testBlockchainjob to the CircleCI configSince there are still too many tests failing I will for now not yet activate this as mandatory. This should nevertheless help a lot improve PR quality (+ reduce failure introduction risk) and should also help us to easier fix the remaining failing blockchain tests, see #338.