Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stateManager cache and trie private #385

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Make stateManager cache and trie private #385

merged 1 commit into from
Nov 7, 2018

Conversation

mattdean-digicatapult
Copy link
Contributor

Now that the vm doesn't access the cache or trie directly (#376) these can be safely renamed to make them private. This PR is part of a long line of stateManager changes; see #309 and #268 for details.

holgerd77
holgerd77 approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@holgerd77 holgerd77 merged commit 6da9f00 into master Nov 7, 2018
@holgerd77 holgerd77 deleted the make-statemanager-cache-trie-private branch November 7, 2018 11:19
@Woodpile37 Woodpile37 mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattdean-digicatapult @holgerd77 @evertonfraga