Fix longer output than return length in call opcode #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
force-pushed
the
fix/call-id-test
branch
from
1cc0b47
to
2fab756
Compare
|
Rebased this. |
axic
reviewed
Feb 26, 2019
| const dataLength = localOpts.outLength.toNumber() | ||
| let dataLength = localOpts.outLength.toNumber() | ||
| if (results.vm.return.length < dataLength) { | ||
| dataLength = results.vm.return.length |
There was a problem hiding this comment.
Could use Math.min to collapse into a single line.
This was referenced May 26, 2024
This was referenced Aug 16, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the case where
outLengthinCALLis longer than the actual data returned, which resulted in the difference being overwritten with zeros. This fixes theCallIdentity_6_inputShorterThanOutputtest case.