Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate index to typescript #507

Merged
merged 3 commits into from
May 13, 2019
Merged

Migrate index to typescript #507

merged 3 commits into from
May 13, 2019

Conversation

s1na
Copy link
Contributor

@s1na s1na commented May 13, 2019

This PR:

  • Updates ethereumjs-blockchain to v4.0.0 (which has type declarations)
  • Migrates src/index.js to typescript
  • Removes the root index.js file, which is not needed anymore

holgerd77
holgerd77 approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning, looks good! 😀

@holgerd77
Copy link
Member

Oh, but breaks the API tests. Likely the blockchain class?

@coveralls
Copy link

coveralls commented May 13, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.005%) to 95.273% when pulling f97b118 on ts/index into a53d432 on v4.

holgerd77
holgerd77 approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that fixed it, we should investigate further on the blockchain library. Will re-approve here.

@s1na
Copy link
Contributor Author

s1na commented May 13, 2019

Thanks. Yeah, this was caused by util.callbackify not being yet merged into browserify (ethereumjs/ethereumjs-blockchain#91 (comment)). When that's merged this issue should hopefully be resolved.

@s1na s1na merged commit 8c4b127 into v4 May 13, 2019
@s1na s1na deleted the ts/index branch May 13, 2019 10:54
@s1na s1na mentioned this pull request May 13, 2019
Merged
23 tasks
@snyk-bot snyk-bot mentioned this pull request Jul 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s1na @holgerd77 @coveralls @evertonfraga