Accept a Common object when constructing the VM and pass it when copying it #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, the VM should probably accept an optional If we do that, |
|
@alcuadrado Yes, that's a good idea to unify the API here. Can you rebase the PR and re-purpose to that and expand the VM constructor with |
alcuadrado
force-pushed
the
pass-hardfork-and-chain
branch
from
c2971ba
to
40c61a4
Compare
alcuadrado
force-pushed
the
pass-hardfork-and-chain
branch
from
40c61a4
to
f0a0ed0
Compare
alcuadrado
changed the title
|
Made the changes mentioned above. This is ready to review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this PR copying a VM always returned one with a
Commonobject set tomainnetandPetersburg. It now passes the chain and hardfork info when copying it.