Remove storageReader and move logic to stateManager #534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StorageReader
had been introduced to cache original storage values for EIP-1283, but I find that the logic can be easily implemented withinStateManager
and there's no need to define a new class and pass it along to many methods and classes.This affects the logic for the
Constantinople
hardfork, and as CI only runs blockchain tests forPetersburg
, I ran those tests forConstantinople
locally and they pass.