Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storageReader and move logic to stateManager #534

Merged
merged 1 commit into from
May 29, 2019
Merged

Conversation

s1na
Copy link
Contributor

@s1na s1na commented May 29, 2019

StorageReader had been introduced to cache original storage values for EIP-1283, but I find that the logic can be easily implemented within StateManager and there's no need to define a new class and pass it along to many methods and classes.

This affects the logic for the Constantinople hardfork, and as CI only runs blockchain tests for Petersburg, I ran those tests for Constantinople locally and they pass.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.992% when pulling 028e1ee on rm-storage-reader into 3e9a91f on master.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very much in favor of this change, simplifies a lot, good that you spotted that.

Looks good.

@s1na s1na merged commit c3311b6 into master May 29, 2019
@s1na s1na deleted the rm-storage-reader branch May 29, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants