Updates to ethereumjs-config v2.0.0 (old) #886

evertonfraga · 2020-09-21T19:35:01Z

This PR removes references to the old ethereumjs-config packages, replacing by the new ones. Configures all the new tooling.

This PR uses gitpkg urls to test monorepo package dependencies prior to their release.

Remaining checks:

Documentation to use unpublished packages with Verdaccio.

Fix lint results

Fix test runners

Other tasks

Fix coverage reporting for all packages
Fix bash errors on script
Point package references to NPM registry after Config release

holgerd77 · 2020-09-21T21:39:57Z

Seems to be pretty "en vogue" in the team these days to have no PR below 40 files changed. 😂 🤣 😅

ryanio · 2020-09-21T22:00:38Z

haha oh yeah, careful with regenerating those docs too 😄

evertonfraga · 2020-09-22T12:48:25Z

@holgerd77 🤣

I can move the docs to another PR, I think that's the most sensible thing to do.

holgerd77 · 2020-09-22T15:34:25Z

@evertonfraga I don't care too much, think we will also get this reviewed with the docs, whatever is more convenient for you.

codecov · 2020-10-08T07:45:33Z

Codecov Report

Merging #886 into master will decrease coverage by 1.27%.
The diff coverage is 90.47%.

Flag	Coverage Δ
#account	`90.00% <ø> (-2.86%)`	⬇️
#block	`75.62% <86.36%> (-1.31%)`	⬇️
#blockchain	`79.80% <100.00%> (-0.34%)`	⬇️
#common	`92.03% <100.00%> (-0.98%)`	⬇️
#ethash	`81.25% <100.00%> (-0.98%)`	⬇️
#tx	`91.79% <100.00%> (-1.30%)`	⬇️
#vm	`87.06% <87.50%> (-1.11%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

evertonfraga · 2020-10-08T08:21:30Z

After review, I'll release the ethereumjs-config 2.0.0, then update here on this branch and merge it!

holgerd77

Nothing to hold off the merge, looks good, thanks Everton for the great work on this!

holgerd77 · 2020-10-08T10:14:43Z

packages/account/.prettierrc

+{
+  "semi": false,
+  "singleQuote": true
+}


No merge blocker, but just for understanding: why are these settings added separately and not as some general configuration?

@holgerd77 So the linting process can occur independently on the CI and locally, for each package.

I understand the repetition, and I can look into alternatives, but I'd rather play on the safer side first, where we can have more granular control over the ethereumjs-config packages

holgerd77 · 2020-10-08T10:21:07Z

packages/account/tsconfig.browser.json

+  "compilerOptions": {
+    "outDir": "./dist.browser"
+  }
+}


These new browser builds needs also be anchored in package.json I guess - see README from config PR, can be tackled in a separate PR though as well eventually.

Update: have added this to the V5 Todo list, so this won't be forgotten.

I would pass on this whole task to @cgewecke - so to eventually integrate and to check that these two new build targets are working as expected and eventually give side effects another thought - if both of you are ok with this.

@holgerd77 I am OK with it, and can follow up with @cgewecke on that.

holgerd77 · 2020-10-08T11:11:19Z

packages/vm/.eslintrc.js

+    'no-unused-vars': 'off',
+    'prefer-const': 'off',
+    'sonarjs/no-duplicated-branches': 'off',
+  }


Ah, so many exceptions for the VM necessary? 😄

No problem of course on this round. Nevertheless interesting to state and see.

yes! there were so many eslint complaints. I decided to add those as exceptions for now, and ship the config sooner, as it's working perfectly.

We can tackle those in other PRs.

holgerd77 · 2020-10-08T11:18:37Z

packages/vm/lib/evm/eei.ts

-      this.refundGas(new BN(this._common.param('gasPrices', 'selfdestructRefund')))
+      this.refundGas(
+        new BN(this._common.param('gasPrices', 'selfdestructRefund'))
+      )


I actually liked the printWidth setting being extended to 100 lines (from 800 or so) on the old format package, this gives a bit more space and there was a somewhat longer discussion around this during the introduction of config until we decided upon this.

This seems to not have made it, was this intentional? (at least I am assuming during re-formattings like the above, haven't concretely checked).

Not sure, should we keep / post-introduce this, any opinions @cgewecke @ryanio or @jochem-brouwer ?

@evertonfraga in doubt and if too much process interrupting merge here anyhow, we'll get this settled out later, eventually with some follow-up PR after discussion just with the linting updates.

holgerd77 · 2020-10-08T11:19:48Z

packages/vm/package.json

    "@ethereumjs/account": "^3.0.0",
    "@ethereumjs/block": "^3.0.0",
    "@ethereumjs/blockchain": "^4.0.3",
    "@ethereumjs/common": "^1.5.1",
    "@ethereumjs/tx": "^2.1.2",
+    "async-eventemitter": "^0.2.4",
+    "core-js-pure": "^3.0.1",


What are these two new dependencies?

@holgerd77 they were already there. I have just moved them to the correct order (@, A-Z)

holgerd77

Reapproval after new commits.

holgerd77 · 2020-10-09T12:49:45Z

@evertonfraga Thanks for the latest updates here, looks great 🙂 , let me know once you need a review!

holgerd77 · 2020-10-20T13:13:44Z

Superseded by #913, will close.

evertonfraga added PR/Issue state: blocked type: docs type: tests type: enhancement package: monorepo labels Sep 21, 2020

evertonfraga added this to the VM v5 milestone Sep 21, 2020

evertonfraga self-assigned this Sep 21, 2020

evertonfraga force-pushed the update-ethereumjs-config branch from 2809f87 to 939cea0 Compare September 21, 2020 19:36

ryanio mentioned this pull request Sep 21, 2020

Release two builds of the project #603

Closed

evertonfraga mentioned this pull request Sep 23, 2020

Optimize bootstrap duration #891

Closed

1 task

evertonfraga force-pushed the update-ethereumjs-config branch 2 times, most recently from 099e073 to 3875a61 Compare October 8, 2020 07:41

evertonfraga added 13 commits October 8, 2020 04:05

tooling: adding clean script

b213a7b

account: Integrating @ethereumjs/config-typescript

da1ce63

git: adding dist.browser to gitignore

07e7aef

Adding dist.browser to prettierignore

ec9b292

Merge

949b250

docs: Add verdaccio documentation

351a193

Ethereumjs Config implementation

095804b

blockchain,vm: Making builds pass

4192398

Using gitpkg urls

25f7241

tooling: Enabling lint on pre-push

ed24f35

account: lint, docs rebuild

019490e

block: lint, docs rebuild

3aac8d0

blockchain: lint, docs rebuild

1639d22

evertonfraga added 8 commits October 8, 2020 04:12

vm: Adding rules to ignore list to be handled later

5f4e756

vm: karma tests tuning

960bfa5

Fixing coverage config

ca29b04

triggering tests

6707424

Fixing eslint dependencies

f7d0482

Package-lock updates

6d6ac9e

Removing merge conflict markers

70c7930

tx: karma concurrency to 1

7108daf

evertonfraga force-pushed the update-ethereumjs-config branch from 8ab611f to 7108daf Compare October 8, 2020 08:13

evertonfraga marked this pull request as ready for review October 8, 2020 08:20

evertonfraga requested review from holgerd77, ryanio and cgewecke October 8, 2020 08:20

holgerd77 mentioned this pull request Oct 8, 2020

VM v5 Release Preparation and Process #907

Closed

39 tasks

holgerd77 previously approved these changes Oct 8, 2020

View reviewed changes

lint: prettier fix on lates PRs merged to master

6628ec5

evertonfraga dismissed holgerd77’s stale review via 6628ec5 October 8, 2020 14:46

holgerd77 previously approved these changes Oct 8, 2020

View reviewed changes

evertonfraga added 3 commits October 8, 2020 16:09

Extending prettier config from parent package

919f8ce

lint: Updated maximum line width to 100

2a7e0f0

updating remote package references

7b7de30

evertonfraga dismissed holgerd77’s stale review via 7b7de30 October 8, 2020 20:22

holgerd77 mentioned this pull request Oct 16, 2020

Updates to ethereumjs-config v2.0.0 (Cherry Pick Edition 🍒 ) #913

Merged

holgerd77 changed the title ~~Updates to ethereumjs-config v2.0.0~~ Updates to ethereumjs-config v2.0.0 (old) Oct 16, 2020

holgerd77 closed this Oct 20, 2020

holgerd77 deleted the update-ethereumjs-config branch October 20, 2020 13:13

cgewecke mentioned this pull request Oct 20, 2020

Add browser field to package.json's of modules with browser builds #921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to ethereumjs-config v2.0.0 (old) #886

Updates to ethereumjs-config v2.0.0 (old) #886

evertonfraga commented Sep 21, 2020 •

edited

Loading

holgerd77 commented Sep 21, 2020

ryanio commented Sep 21, 2020

evertonfraga commented Sep 22, 2020

holgerd77 commented Sep 22, 2020

codecov bot commented Oct 8, 2020 •

edited

Loading

evertonfraga commented Oct 8, 2020

holgerd77 left a comment

holgerd77 Oct 8, 2020

evertonfraga Oct 8, 2020 •

edited

Loading

holgerd77 Oct 8, 2020

holgerd77 Oct 8, 2020

holgerd77 Oct 8, 2020

evertonfraga Oct 8, 2020

holgerd77 Oct 8, 2020

evertonfraga Oct 8, 2020

holgerd77 Oct 8, 2020

holgerd77 Oct 8, 2020

evertonfraga Oct 8, 2020

holgerd77 left a comment

holgerd77 commented Oct 9, 2020

holgerd77 commented Oct 20, 2020

Updates to ethereumjs-config v2.0.0 (old) #886

Updates to ethereumjs-config v2.0.0 (old) #886

Conversation

evertonfraga commented Sep 21, 2020 • edited Loading

Fix lint results

Fix test runners

Other tasks

holgerd77 commented Sep 21, 2020

ryanio commented Sep 21, 2020

evertonfraga commented Sep 22, 2020

holgerd77 commented Sep 22, 2020

codecov bot commented Oct 8, 2020 • edited Loading

Codecov Report

evertonfraga commented Oct 8, 2020

holgerd77 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evertonfraga Oct 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

holgerd77 left a comment

Choose a reason for hiding this comment

holgerd77 commented Oct 9, 2020

holgerd77 commented Oct 20, 2020

evertonfraga commented Sep 21, 2020 •

edited

Loading

codecov bot commented Oct 8, 2020 •

edited

Loading

evertonfraga Oct 8, 2020 •

edited

Loading