Cleanup on external API exposure

[holgerd77]

Closes #924

Ok, not the big sweeping blow I had hoped for but at least some substantial cleanup on what is exposed to the external API. Renamed some clearly internal members to underscore to better differentiate from the officially exposed functionality, also added protected keywords where possible so that these members are then not documented in the API docs.

Following reasoning and classifications for the respective member changes:

Categories

• 1 ^= Not meant to be public at all -> _ and private
• 2 ^= Not meant to be public but might be used in custom implementations -> _ and protected
• 3 ^= Should be part of the official API
• 4 ^= Not part of the official API, but is externally used -> _ and no explicit visibility

Name	Category	Assignment	Change ->
opts	2	index.ts	_opts
allowUnlimitedContractSize	2	index.ts	_allowUnlimitedContractSize
isInitialized	2	index.ts	_isInitialized
_opcodes	2	index.ts	_opcodes, added protected
stateManager	3	index.ts	added comment for docs
blockchain	3 (?)	index.ts	added comment for docs
_common	4	index.ts	heavily used in tests
_emit	1	index.ts	needs to be kept public due to code construction, added @hidden comment
_mcl	1	index.ts	needs to be kept public due to code construction, added @hidden comment

I also fixed the docs generation accidentally including the tests along the way and regenerated documentation.

[codecov]

Codecov Report

Merging #925 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Flag	Coverage Δ
#block	75.79% <ø> (-0.22%)	⬇️
#blockchain	80.33% <ø> (-0.39%)	⬇️
#common	91.79% <ø> (ø)
#ethash	82.08% <ø> (ø)
#tx	88.37% <ø> (ø)
#vm	87.17% <100.00%> (+0.21%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[holgerd77]

Note: _emit needs to be kept public as well, had this wrong in the first version of the initial comment (in case you read on mail), have updated.

[jochem-brouwer]

Shouldn't stateManager, blockchain, common be marked readonly?

[holgerd77]

Yes, good point, have added in e50af80. Realized that I actually had a wrong understanding of the Readonly modifier.

[jochem-brouwer]

Looks great! 👍