-
Notifications
You must be signed in to change notification settings - Fork 817
Audit dependencies and clean up dependency tree #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
@rumkin This looks like a great start on this, cool! 👍 Two notes:
|
@holgerd77 Thanks for reviewing it so quickly!
|
Short informational note: I've just merged #953 from @evertonfraga which is bringing the cd ethereumjs-vm
npm run bootstrap
git submodule init
git submodule update (takes a while since several 100MB of package size) |
d951949
to
98e20f4
Compare
Rebased changes from #953 through master branch. |
@rumkin have given this a "WIP" label, please change to "PR: Ready for review" label once you consider this ready and - important - also drop a note here, since this label change - won't trigger a separate notification by GitHub. |
@holgerd77 Done. It's ready now. I think someone need to reproduce audit independently. I've described actions to be made in the comment to original issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can confirm the vulnerabilities on the VM going to 0 on a packaged install, thanks Paul!
This PR fixes #952 issue to remove vulnerable dependencies from EthereumJS libraries.
TODOLIST
@ethereumjs/block
@ethereumjs/blockchain
@ethereumjs/common
@ethereumjs/ethash
@ethereumjs/tx
@ethereumjs/vm