Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

Adopt EIP-658 #92

Open
pyskell opened this issue Apr 20, 2018 · 1 comment
Open

Adopt EIP-658 #92

pyskell opened this issue Apr 20, 2018 · 1 comment

Comments

@pyskell
Copy link
Contributor

pyskell commented Apr 20, 2018

ETH recently introduced the REVERT opcode to allow for a transaction failure that does not consume all gas. As a side-effect they've had the status element of a transaction receipt start actually returning a succeeded/failed status; rather than null as seen prior to their Byzantium fork, and on the ETC blockchain.

While ETC does not necessarily need EIP-658 to function adequately I believe it would be nice to have so that those used to having status available on the ETH chain also find it as they expect on ETC.

Concerns:

  • This may be a breaking change for software that depends on status being null, although this may be a rare occurrence.
  • It may not be worth forking exclusively for this change so will likely want to tack this on to another hard fork.

Reference: http://eips.ethereum.org/EIPS/eip-658

@Dexaran
Copy link
Member

Dexaran commented Apr 21, 2018

As a smart-contract developer, I would say that REVERT opcode implementation is an important detail for smart-contract development & compatibility with current Remix IDE.

I support EIP658 implementation in ETC.

Also, I think that implementation details should not differ from ETH for compatibility reasons. Thus, I think that status should work exactly as it is working in ETH version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants