Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getNumberOfPayouts() no revert for non existent processId #108

Open
rapidddenis opened this issue May 29, 2023 · 1 comment
Open

getNumberOfPayouts() no revert for non existent processId #108

rapidddenis opened this issue May 29, 2023 · 1 comment
Assignees

Comments

@rapidddenis
Copy link

function getNumberOfPayouts(bytes32 processId) external view returns(uint256 numberOfPayouts) {

all manually defined getters are reverting if id is non existent.

@rapidddenis rapidddenis changed the title getNumberOfPayouts no revert for non existent processId getNumberOfPayouts() no revert for non existent processId May 30, 2023
@matthiaszimmermann matthiaszimmermann self-assigned this May 31, 2023
@matthiaszimmermann
Copy link
Contributor

true, we might want to consider adding a payoutsCount to IPolicy.Policy and get rid of payoutCount mapping in the PolicyController. this would result in the unification of the approach for the getters.

needs some further analysis on how to best refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants