Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processPremium should check balance #97

Open
christoph2806 opened this issue Feb 25, 2023 · 0 comments
Open

processPremium should check balance #97

christoph2806 opened this issue Feb 25, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@christoph2806
Copy link
Member

In TreasuryModule

gif-contracts/contracts/modules/TreasuryModule.sol

Line 238 in b9af399

function processPremium(bytes32 processId)

the amount to collect is calculated as premiumExpectedAmount - premiumPaidAmount. This will cause a revert in case of insufficient balance on the account. Amount collected should be min(balance, premiumExpectedAmount - premiumPaidAmount)
@doerfli doerfli added the bug Something isn't working label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christoph2806 @doerfli