Will TransactionResponse type always have r,s,v defined?

[mds1]

The Transaction type has r,s,v as optional fields. The TransactionResponse type extends Transaction, but does not make r,s,v required fields.

Is this an oversight, or are there cases when TransactionResponse will not have r,s,v defined? If the latter, what scenarios? Every transaction must have a valid signature so I'd expect r,s,v to be required in this type.

For context, I'm recovering a public key from a transaction hash, so I noticed this when getting the signature from the transaction:

const tx = await ethersProvider.getTransaction(txHash);
const splitSignature: SignatureLike = {
    r: tx.r as string, // without casting here, TypeScript complains since `tx.r` may be `undefined`
    s: tx.s,
    v: tx.v,
  };
  const signature = joinSignature(splitSignature);

On a side note, it seems getTransaction isn't in the documentation. Am I missing it somehow, or is there an alternate way to do the above?

[ricmoo]

You are right about the docs, I’ll add it shortly.

There were cases where r, s and v were not present. I’m trying to remember why though, but it was deliberate.

Possibly Ganache did not include these? Or Etherscan? I’ll have to scratch my brain tonight and try to recall. But I do remember things breaking when they were required properties.

[ricmoo]

The docs were updated a while ago with the getTransaction method. I can't find examples where r, s and v are not populated, but that is a change I don't want to make in v5. In v6 the Transaction object is much stricter, so they won't be optional.

Thanks! :)

[roflganker]

@ricmoo

There were cases where r, s and v were not present. I’m trying to remember why though, but it was deliberate.

Well I found a matching case 😅
#3926 (comment)