bytes: fix isBytes check

[ChALkeR]

Otherwise this passed on e.g. an array of NaNs.

As a rule of thumb, using fail-closed checks is safer than using fail-open checks, e.g. if (!(...check for good values)) fail is safer than if (check for bad values) fail, as e.g. NaN here bypasses any of those, returning falsy on every of v < 0, v >= 256 and v % 1 checks.

Refs:

• Ethers very confusingly treats BN values as zero. #1172
• https://tc39.es/ecma262/#sec-number.isinteger

[ricmoo]

I completely agree! I'll update this soon.

Thanks! :)

[ricmoo]

Merged into 5.5.0.

Thanks! :)