Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar IPFS support when CAIP-22 is used. #2272

Closed
tlammens opened this issue Nov 5, 2021 · 1 comment
Closed

Avatar IPFS support when CAIP-22 is used. #2272

tlammens opened this issue Nov 5, 2021 · 1 comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@tlammens
Copy link

tlammens commented Nov 5, 2021

When the avatar field conforms to CAIP-22 and the tokenURI is requested it can return an IPFS URI referring to the metadata JSON as per ERC721.
The image inside the metadata JSON can also be a IPFS URI.

Have created a PR with the supporting code #2271
Referring to #2185
@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. labels Nov 17, 2021
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Feb 4, 2022
@ricmoo
Copy link
Member

ricmoo commented Feb 4, 2022

This should be published already, linked to in the above PR.

Thanks! :)

@ricmoo ricmoo closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @tlammens