fix: return eth_chainId as hexadecimal #2711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[An EIP1193 _must_ return chainId as a hexadecimal.](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1193.md#:~:text=chainId%20MUST%20specify%20the%20integer%20ID%20of%20the%20connected%20chain%20as%20a%20hexadecimal%20string%2C%20per%20the%20eth_chainId%20Ethereum%20RPC%20method.) Updates `eth_chainId` calls on the `Eip1193Bridge` to convert the decimal chainId returned by `this.provider.getNetwork()` to a hexadecimal.
ricmoo
added
bug
ricmoo
added a commit
that referenced
this pull request
Mar 2, 2022
|
This has been fixed in v5.6. Let me know if you still have any issues. Thanks! :) |
ricmoo
added
fixed/complete
This was referenced Apr 12, 2022
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An EIP1193 must return chainId as a hexadecimal (spec).
Updates
eth_chainIdcalls on theEip1193Bridgeto convert the decimal chainId returned bythis.provider.getNetwork()to a hexadecimal.