Format API results inside _wrap*
methods
#3818
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 4 wrapping methods in
AbstractProvider
:_wrapBlock
_wrapLog
_wrapTransactionReceipt
_wrapTransactionResponse
For some reason,
formatTransactionResponse
was not being called in_wrapTransactionResponse
, although the analogous functions were being called in other wrapping methods.Also, for some reason, formatting functions were being called on the arguments of wrapping methods before being passed in, even though they are called inside as well.
This PR fixes the inconsistencies.
The argument for formatting functions to be called inside wrapping methods is that if we want to override the formatters in the derived Provider class (say, if a network has extra fields in
Block
orTransactionReceipt
), it is much easier to do so by overriding wrapping methods than by overriding every method that calls wrapping methods.