feat: wait for postage stamp to be usable when bying it #352
Conversation
🐝 PR preview in SwarmPreview URL: https://bah5acgza3cqaahd4cdcan54ekeqq3nctmhvpqxphpxzz7pjixxrewj4njxyq.bzz.link |
src/utils/index.ts
Outdated
| const timeoutPromise = (): Promise<never> => | ||
| new Promise((_, reject) => | ||
| setTimeout(() => { | ||
| timeoutReached = true | ||
| reject(new Error('Wait until stamp usable timeout has been reached')) | ||
| }, timeout), | ||
| ) | ||
|
|
||
| const stampWaitPromise = async (): Promise<PostageBatch | undefined> => { | ||
| while (!timeoutReached) { | ||
| const stamp = await beeDebug.getPostageBatch(batchId) | ||
|
|
||
| if (stamp.usable) return stamp | ||
| await sleepMs(pollingFrequency) | ||
| } | ||
| } |
There was a problem hiding this comment.
I usually do this with for loops, I think the upside is you don't need to race promises, no need for a separate setTimeout for the rejection, and the implementation is a single block that is simpler IMHO.
I am fine with this as well, just wondering if this has some pros I am unaware of 🙂
There was a problem hiding this comment.
Hey! Actually no benefits, mostly really just complications. I will refactor, thanks for the suggestion :)
There was a problem hiding this comment.
The only advantage is that it spends exactly the timeout time unlike for loop which also adds the time spent on requests to check the stamp is usable . I don't see that as a problem, just wanted to point it out :)
resolves #321
This is a very minimal implementation of the functionality. I would like to point out that the UX here is pretty bad as it does not tell the user what is happening (e.g. the stamp was bought waiting for it to be usable) and if for whatever reason the stamp is not usable until the
DEFAULT_STAMP_USABLE_TIMEOUT = 120_000is reached, it will fail with error message. My suggestion would be to merge this PR but have a design session with David how to improve the UX. On mainnet purchasing the stamp will take 30-90 seconds and then waiting for it to be usable also takes up to 90 seconds.