Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add map with peers to info page #398

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

vojtechsimetka
Copy link
Contributor

@vojtechsimetka vojtechsimetka commented Jun 19, 2022

Screenshot 2022-06-19 at 21 01 38

@bee-worker
Copy link
Collaborator

bee-worker commented Jun 19, 2022

🐝 PR preview in Swarm

Preview URL: https://bah5acgzaxgqzhqj7fvelcgqq7dho6aqdhj34mn3t4rwx3aqvoejxjildymda.bzz.link
Swarm Hash: b9a193c13f2d48b11a10f8ceef02033a77c63773e46d7d8215711374a163c306
Commit Hash: e905480
Commit Message: feat: nodes-db should be sorted alphabetically by key

@AuHau
Copy link
Contributor

AuHau commented Jun 19, 2022

Wait, so there will be ~300kB file containing all the Swarm's known nodes with their locations distributed for the map source? Will this be only for Desktop or also for general Dashboard functionality?

@vojtechsimetka
Copy link
Contributor Author

Wait, so there will be ~300kB file containing all the Swarm's known nodes with their locations distributed for the map source? Will this be only for Desktop or also for general Dashboard functionality?

Yes. Until we get IP or location data from Bee :/.

We talked about this and this is the easiest solution. We will also add two more libraries that can detect your own IP address and another one to deduce location from it (https://www.npmjs.com/package/fast-geoip). Although this part I am not super sure about yet and would like to discuss again - I don't think it adds too much value for this cost.

But to answer your question. Size is not too much of a concern here. Most users will use bee-dashboard bundled in bee-desktop, swarm-extension or direct global npm install. Those who will access it from a website are still likely on a good connection as they run their own node and are likely on computer (bee-dashboard is not really usable on mobile). I understand your comment and I align with it, but I think we are reasonable here.

@vojtechsimetka vojtechsimetka marked this pull request as ready for review June 19, 2022 19:13
@vojtechsimetka vojtechsimetka requested a review from Cafe137 as a code owner June 19, 2022 19:13
@AuHau
Copy link
Contributor

AuHau commented Jun 20, 2022

Alright, you convinced me 😆 But yeah, lets try to get Bee to expose the peer's addresses...

@vojtechsimetka vojtechsimetka merged commit 2be9735 into master Jun 20, 2022
@vojtechsimetka vojtechsimetka deleted the feat/add-map-to-info-page branch June 20, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants