Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transfer everything out of the gift wallet #456

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

vojtechsimetka
Copy link
Contributor

So this is by no means perfect:

  • It does not have any retry mechanism
  • it does not correctly check on the UI if the balance is enough for both of the transfers.

But I think it is improvement over what is there right now. I would like to do a complete refactor of this code later (we are creating providers all the time, I think we can better encapsulate things etc).

src/utils/rpc.ts Outdated Show resolved Hide resolved
@bee-worker
Copy link
Collaborator

bee-worker commented Jun 29, 2022

🐝 PR preview in Swarm

Preview URL: https://bah5acgzah6ldlwh5umtuwy5bjhnsgt3r6qigt6fn2vpxigdx4xymokpulgha.bzz.link
Swarm Hash: 3f9635d8fda3274b63a149db234f71f41069f8add55f741877e5f0c729f4598e
Commit Hash: 966ad05
Commit Message: refactor: extract bzz token address into variable

Copy link
Member

@agazso agazso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's try to add retry logic later.

@vojtechsimetka vojtechsimetka merged commit 7225c5c into master Jun 29, 2022
@vojtechsimetka vojtechsimetka deleted the feat/gift-wallet-transfer-everything branch June 29, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants