You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking on what is exposed as part of the Utils namespace, I think there is a lot of parts that are purely internal and I am not sure why user should have access to it. Especially as it extends the public API that is then tightened to SemVer.
export*asCollectionsfrom'./collection'// <- should expose only the helpers the @Cafe137 createdexport*asBytesfrom'./bytes'// <- also not sure if it is neededexport*asDatafrom'./data'// <- I would definitely remove this oneexport*asFilefrom'./file'// <- This will be removed in the directory streaming PRexport*asHexfrom'./hex'// <- I guess this one makes senseexport*asTarfrom'./tar'// <- I would definitely remove this oneexport*asEthfrom'./eth'// <- This one makes senseexport*asHooksfrom'./hooks'// <- This one could be only deprecated with the Fetch PR, but if we gonna have breaking release we might remove it as well.export*asPssfrom'./pss'export{setDefaultHeaders}from'./safe-axios'export{keccak256Hash}from'./hash'
The text was updated successfully, but these errors were encountered:
Maybe I would go as far as not having export * because it can have unintended consequences. For example an internal utility function exposed publicly, then after an internal refactor landing in a different file would break the public API.
@r0qs is there anything in the above list that would negatively affect you?
Hi, thanks for considering my use case. I indeed use those functions, mostly the eth, hex and bytes modules.
But after our discussion around the issue #379 I decided to do my own wrapper around the bee api to have more control over the feeds and pss functionalities.
So this change will not affect me anymore:)
Looking on what is exposed as part of the
Utils
namespace, I think there is a lot of parts that are purely internal and I am not sure why user should have access to it. Especially as it extends the public API that is then tightened to SemVer.The text was updated successfully, but these errors were encountered: