Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Swarm CID references #648

Closed
nugaon opened this issue Apr 27, 2022 · 3 comments · Fixed by #681
Closed

Support Swarm CID references #648

nugaon opened this issue Apr 27, 2022 · 3 comments · Fixed by #681
Labels
type:issue

Comments

@nugaon
Copy link
Member

nugaon commented Apr 27, 2022

Swarm has already CID library and also CID based linking {cid}.bzz.link.
Would be awesome, if bee-js also supported this kind of reference.
@vojtechsimetka
Copy link
Contributor

Thanks for the issue. This is actually a topic of our internal discussion today, in general we would love to add such support :).

@AuHau
Copy link
Contributor

AuHau commented May 9, 2022

We will implement solution where:

  • we will accept CIDs and decode them using the swarm-cid-js library
  • we will extend the UploadResult interface into CIDUploadResult that will be returned on upload methods for which we have CID support (manifests, and feeds)

@AuHau AuHau mentioned this issue May 19, 2022
Merged
@bee-worker
Copy link
Collaborator

Release v4.1.0 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: cids support ethersphere/bee-js
4 participants
@AuHau @vojtechsimetka @nugaon @bee-worker