Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ens support for download methods #659

Merged
merged 4 commits into from
May 11, 2022
Merged

feat: ens support for download methods #659

merged 4 commits into from
May 11, 2022

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented May 3, 2022

Closes #647

src/utils/type.ts Outdated Show resolved Hide resolved
@AuHau AuHau force-pushed the feat/ens-download branch from 032fe68 to 37332ef Compare May 3, 2022 08:14
test/unit/assertions.ts Outdated Show resolved Hide resolved
src/utils/type.ts Outdated Show resolved Hide resolved
@AuHau
Copy link
Contributor Author

AuHau commented May 3, 2022

Btw. the idna-uts46-hx package is quite a big one 😳 It adds 160kb minified. See our deps including this package here.

@AuHau AuHau force-pushed the feat/ens-download branch from a406ba9 to 09ec25f Compare May 11, 2022 08:57
@AuHau AuHau requested a review from vojtechsimetka May 11, 2022 09:40
src/utils/type.ts Outdated Show resolved Hide resolved
test/unit/assertions.ts Show resolved Hide resolved
@AuHau AuHau merged commit e72c4b4 into master May 11, 2022
@AuHau AuHau deleted the feat/ens-download branch May 11, 2022 10:14
@bee-worker
Copy link
Collaborator

Release v4.0.0 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ENS on download functions
3 participants